Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change subscription details based on platform #17509

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#28910

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 7, 2023
@deeppandya deeppandya added this to the 1.51.x - Nightly milestone Mar 7, 2023
@deeppandya deeppandya self-assigned this Mar 7, 2023
@deeppandya deeppandya added CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Mar 7, 2023
@deeppandya deeppandya merged commit eb9084c into master Mar 8, 2023
@deeppandya deeppandya deleted the change_subscription_detail_behaviour branch March 8, 2023 16:48
brave-builds added a commit that referenced this pull request Mar 8, 2023
brave-builds added a commit that referenced this pull request Mar 8, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 9, 2023

Verification PASSED

Steps:

  1. Purchased VPN in Prod (account.brave.com) via Desktop
  2. Redeemed/logged in Android Device
  3. Enabled VPN via Settings menu
  4. Verify Status and Expires fields in Settings =>Brave Firewall + VPN modal

Confirmed Subscription fields are hidden for desktop subscription i.e. when logged in to Android device with desktop prod VPN credentials.

ex ex ex
screenshot_20230309_112044_gallery_720 screenshot_20230309_111740_brave_-_nightly_720 screenshot_20230309_111836_brave_-_nightly_720

Confirmed Subscription fields are shown for in-app purchase on Android device

ex ex ex
Screenshot_20230309_134732_Brave - Nightly Screenshot_20230309_135604_Brave - Nightly

kjozwiak pushed a commit that referenced this pull request Mar 14, 2023
kjozwiak pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide in app purchase details
4 participants